-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uppercase labels too #380
Uppercase labels too #380
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
======================================
Coverage 14.2% 14.2%
======================================
Files 55 55
Lines 1267 1267
======================================
Hits 180 180
Misses 1087 1087
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @skjnldsv , I don't think it's a good idea to keep console statements.
@xh3n1 I don't think either. I'm an idiot! 😂 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
acb5d1f
to
08e4916
Compare
@xh3n1 ok now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully capitalizing looks veeery screamy and out of place. ;) We should just use »Home«, »Work«, »Mobile«, »Work pager«, »Telex«, »Home fax«, »Fax« etc.
@jancborchardt did you test the pr? ^^' |
@skjnldsv sorry, I looked at the comment in #67 (comment) and assumed that’s how it’s going to be displayed. ;) |
@jancborchardt Don't worry, made me laugh! 😝 ❣️ |
I'm happy to entertain :D |
Fix #67
Test vcf: cd159d83-5833-44ec-a3df-1e91b085ef28.txt